Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask home: update to brew.sh #6014

Merged
merged 2 commits into from
Apr 14, 2019
Merged

cask home: update to brew.sh #6014

merged 2 commits into from
Apr 14, 2019

Conversation

vitorgalvao
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Affects man brew-cask and brew cask home with no arguments. Before this change it would open https://caskroom.github.io/, which was redirecting to https://brew.sh/ anyway.

@reitermarkus
Copy link
Member

I think we should also deprecate this.

@vitorgalvao
Copy link
Member Author

I think we should also deprecate this.

brew cask home {{cask}} will still need to work. Why deprecate brew cask home without an argument?

@MikeMcQuaid MikeMcQuaid merged commit 3b842ef into Homebrew:master Apr 14, 2019
@MikeMcQuaid
Copy link
Member

Why deprecate brew cask home without an argument?

I guess because it no longer makes sense without the brew cask project having a separate homepage. I agree with the deprecation FWIW 👍

@MikeMcQuaid
Copy link
Member

Thanks @vitorgalvao! 🎉

@vitorgalvao vitorgalvao deleted the caskroom-home branch April 14, 2019 11:50
@lock lock bot added the outdated PR was locked due to age label May 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitorgalvao @reitermarkus @MikeMcQuaid